-
-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check cloud vendor availability #128
Comments
A note about which vendor is still checking.
cc @jlipps |
Hello everyone. Thanks for adding your vendor availability in AppiumDesktop. The backend is going to W3C based client (web2driver(webdriverio as its backend)) for Appium 2.0.
The below mention is based on relevant contributors related to each vendor in Appium-Desktop.
cc @wswebcreation (I know you already checked in another issue. Thanks so much!) Thank you so much for your contributions, again. |
note: #118 is a known issue. |
@KazuCocoa Thanks for mentioning. Should we check with the latest master code or the latest release of appium-inspector i.e. 2021.8.5? |
I think #118 branch should try first. (although potentially the same issue addressed in the PR happen) |
https://github.com/appium/appium-inspector#development is how to launch the inspector instance |
Thanks for letting us know. We've sent a PR with a fix for TestingBot integration: #130 |
Thanks for the heads up, we will start working on it as soon as possible. |
@KazuCocoa I've created a PR for fixing the integration with BrowserStack. Can you please review and merge? #139 |
@KazuCocoa and @jlipps , Sauce now works with this version We now need to fix accepting W3C caps on real devices which we didn't supported yet. If issues come to this repo then please close them and or ping me in them |
I created a ticket with Bitbar around this issue and they said they would deploy a fix today the 29th. I just tried it and indeed it is fixed. |
I checked the Inspector code, and indeed the |
I think ExperiTest and BitBar haven't responded here. |
@vishalweb, I was experiencing an issue with Appium Inspector 1.x and that is what Bitbar fixed. I did see the error your seeing with Inspector 2.0. I suspect the Bitbar possibly does not have support for Appium 2.0 but that just my guess. |
Ok, I've sent a support email to BitBar and ExperiTest. |
Thanks @PatrickFlaherty , @KazuCocoa and @jlipps . Will check with Appium Inspector 1.x version and wait for update from Bitbar on support ticket raised Update 5 oct 2021: Checked on Appium Desktop 1.20.2 Appium inspector, issue has been fixed as mentioned by @PatrickFlaherty, able to connect to bitbar android and iOS . Issue still exists with Standalone Appium Inspector 2.0 for which @KazuCocoa has already raised a support ticket with Bitbar |
This error is not a Bitbar response. Library used in this project validates capabilities before sending and this is the result. Example: Bitbar accepts many formats for same capability regarding custom Bitbar capabilities. Including ones not in W3C spec with too long backward compatibility. Assuming there is capability named ‘name’:
Options 1. and 2. are blocked by library used in this project. It’s most likely possible to disable this validation. Not all libraries do this. If this application is going to differentiate between vendor specific caps and appium ones prefixing both with separate prefixes, here is a list of bitbar specific capabilities: |
This is a webdriverio restriction which we can't change as far as I'm aware. What seems necessary is to simply update the section where hardcoded bitbar caps are introduced and add an appropriate prefix to them. Do you feel comfortable proposing that PR? Any bitbar specific caps which are added by the user themselves we can simply require that the user use W3C-valid caps, which is fine. |
Hi @jlipps , Update 5 oct 2021: Checked on Appium Desktop 1.20.2 Appium inspector, issue has been fixed as mentioned by @PatrickFlaherty, able to connect to bitbar android and iOS . Issue still exists with Standalone Appium Inspector 2.0 for which @KazuCocoa has already raised a support ticket with Bitbar So the issue has been resolved by bitbar for the embedded Appium inspector in Appium desktop. Please suggest if there is a proposed fix for this, as going forward, we would need to use Appium inspector standalone. Appium inspector with checkbox ticked for automatically adding prefix, get below error Without checking checkbox for prefixes, below error Note: Able to connect with Bitbar devices through embedded Appium inspector in Appium desktop v1.20 as mentioned in comment update 5 oct 2021 |
Like other vendors did in #128 (comment), we still need BitBar's help to update their capabilities (probably only: appium-inspector/app/renderer/actions/Session.js Lines 312 to 313 in 6dd350a
The reason why embedded Appium inspector in Appium desktop v1.20 worked was the old inspector followed non-W3C spec capabilities which would no longer work in Appium 2.0. This inspector is also going to follow W3C WebDriver spec. Vendors in #128 (comment) have updated their capabilities in this inspector to follow W3C spec. (They have added their own vendor prefix in their own capabilities.) |
Thanks @KazuCocoa |
Probably he no longer works there. (then, sorry for frequent mention to him) I've sent emails as #128 (comment) so we only can wait for their actions. Nothing can do on this issue. |
Correct - I worked at Bitbar briefly in 2018, and have not been employed there in a while. However, when I got the first notification of this issue, I forwarded the email to my former colleagues to let them know. In case you are still having issues, the best avenue is probably to contact their support via official routes. Best regards, |
Thanks @Walther . We will contact Bitbar support. |
https://github.com/appium/appium-inspector/releases/tag/v2021.12.2 has most of fixes. |
Appium Inspector has a feature to connect to cloud vendor environments. Each vendor contributed to AppiumDesktop to allow AD to attach to their environment.
This repository (appium-inspector) now uses web2driver, which uses webdriverio as its backend, to support W3C spec capabilities for Appium 2.0. Appium 2.0 will drop MJSONWP style, so this change is mandatory as appium inspector.
Then, potentially vendors have an issue in their connectivity. I guess especially vendors modify
desiredCapabilities
might affect them.The text was updated successfully, but these errors were encountered: