Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

robotic.mobi: adding options 'source' capability #146

Merged
merged 2 commits into from
Sep 22, 2021
Merged

robotic.mobi: adding options 'source' capability #146

merged 2 commits into from
Sep 22, 2021

Conversation

donmezburak
Copy link
Contributor

robotic.mobi: adding options 'source' capability

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 21, 2021

CLA Signed

The committers are authorized under a signed CLA.

Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Could you sign the CLA as well?

app/renderer/actions/Session.js Outdated Show resolved Hide resolved
@donmezburak
Copy link
Contributor Author

Done. When will this commit merge into master and publish as product ?

@jlipps
Copy link
Member

jlipps commented Sep 22, 2021

@donmezburak the lint error has not been fixed. please fix it and push the change and when CI passes we'll be able to merge this.

@donmezburak
Copy link
Contributor Author

Sorry I see the problem now. Fixed it.

@KazuCocoa KazuCocoa merged commit a368b5b into appium:jlipps/fix-package Sep 22, 2021
@jlipps
Copy link
Member

jlipps commented Sep 22, 2021

Hmm I just noticed this was merged into jlipps/fix-package instead of master. It should probably be in master instead?

@jlipps
Copy link
Member

jlipps commented Sep 22, 2021

I mean main

@KazuCocoa
Copy link
Member

oh, yea..

@donmezburak
Copy link
Contributor Author

I thought you will merge into main. If you wish, I can create another pr for main

jlipps pushed a commit that referenced this pull request Sep 22, 2021
* robotic.mobi: adding options 'source' capability

* robotic.mobi - fix lint problem.
@jlipps
Copy link
Member

jlipps commented Sep 22, 2021

I have merged it into main. FWIW, the branch you targeted was for an unrelated change, that was partly why I was confused.

@donmezburak
Copy link
Contributor Author

When I saw your mail , I thought this branch I would have to use to create pr. Thanks for reply and merge.

Screen Shot 2021-09-23 at 11 23 42

@jlipps
Copy link
Member

jlipps commented Sep 23, 2021

ahhh, that was the jlipps/fix-conns branch, not the jlipps/fix-package branch. but now I understand what happened. thank you :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants