fix: fix updater #1407
Merged
fix: fix updater #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto fix-auto-updater
github-actions
bot
added
dependencies
| type: 'info', | ||
| message: t('appiumIsAvailable', {name: version}), | ||
| buttons: [t('Install Now'), t('Install Later')], | ||
| detail: t('updateDetails', {pubDate, notes: RELEASES_LINK}), |
There was a problem hiding this comment.
would it be possible to show release notes for the particular version?
There was a problem hiding this comment.
I did investigate this option, but decided against it for several reasons:
- The raw release notes string requires post-processing to make it readable (remove HTML tags with regex, handle multi-level bullet points, etc)
- The release notes can get quite large and cause the floating box buttons to go out of bounds, preventing any user interaction. I mainly observed this with the raw release notes string, but there is still a possibility that it can apply to the post-processed notes in the future. A quick search for scrolling options inside this box also didn't give me any results.
- The user may skip one or more versions during the update, and showing the changelog only for the most recent version is not sufficient, in my opinion
Still, the floating box does have another problem - it cannot render clickable links, so the link shown here is unfortunately just text.
There was a problem hiding this comment.
This is not very useful if it is just a text.
Anyway, I believe we could still show release notes nicely either by creating a HTML view or just using something link html-to-text to render it as a text and have scrolling there. Not for this PR though
mykola-mokhnach
approved these changes
Apr 5, 2024
jlipps
reviewed
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the long-outstanding issue with the updater not working. It reverts from the custom implementation based on the stock Electron updater, to a simpler version based on
electron-updater.For now the implementation only works through the manual 'Check for Updates' button, but it should not be too difficult to also add automatic checking in the future, once it's certain that the manual approach works fine.
Most of the code related to the old updater implementation has also been removed.
I did also test this functionality. This was done by changing the application version in
package.jsonto a smaller number, packaging it into an installer, installing it, and then checking for updates. On macOS I ran into an error when clicking restart after the 'newer' version was downloaded - I believe this is likely due to different code signing identities. On Windows the process worked fine, although there was an odd ENOENT warning upon launching the updated version, which did not appear upon reopening the app - maybe related to differentpublishoptions.Despite the above problems, I think the change is still an improvement and is worth merging in its current state. Perhaps the issues will disappear when updating between two production versions.
Fixes #733.