Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: implement Chromium driver and options #1995

Closed
AlessandroMiccoli opened this issue Sep 1, 2023 · 4 comments · Fixed by #2003
Closed

[Feat]: implement Chromium driver and options #1995

AlessandroMiccoli opened this issue Sep 1, 2023 · 4 comments · Fixed by #2003

Comments

@AlessandroMiccoli
Copy link
Contributor

The implementation for the Chromium driver, including the options, needs to be included.

Are you interested to have it?

So, we could have the implementation directly from the library without making a custom into the project.

@mykola-mokhnach
Copy link
Contributor

Sure, feel free to prepare a PR describing the necessary option classes

@AlessandroMiccoli
Copy link
Contributor Author

AlessandroMiccoli commented Sep 4, 2023

I started working on it, seeing multiple options: appium and goog. I have a few questions that could save me some time:

  1. Appium options: in some cases, they have a default value. Do I need to consider it? My answer is no because if I decide to implement the option, in some ways, I am not happy with the default value.
  2. Goog options:
    - in some cases, have a dictionary type. Is it a Map<String,Object>?
    - perfLoggingPrefs capability has a set of defined optional keys. Do I need to throw an exception if the key provided is not on the list?

@AlessandroMiccoli
Copy link
Contributor Author

@mykola-mokhnach I created a pull request for this #2003. I am waiting for the above points, to continue to work on it.

@mykola-mokhnach
Copy link
Contributor

I started working on it, seeing multiple options: appium and goog. I have a few questions that could save me some time:

  1. Appium options: in some cases, they have a default value. Do I need to consider it? My answer is no because if I decide to implement the option, in some ways, I am not happy with the default value.

Let the server to decide. IMHO any logic on the client side would be an unnecessary overhead

  1. Goog options:
    • in some cases, have a dictionary type. Is it a Map<String,Object>?

Yes, dictionary and map are the same thing

  • perfLoggingPrefs capability has a set of defined optional keys. Do I need to throw an exception if the key provided is not on the list?

Same as above, let the server to decide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants