Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 issues #12

Open
Philippe91 opened this issue Nov 19, 2022 · 0 comments
Open

3 issues #12

Philippe91 opened this issue Nov 19, 2022 · 0 comments

Comments

@Philippe91
Copy link

const static uint8_t lenbits = FLAGLEN;

should be:

const static uint8_t lenbits = (7 - FLAGLEN);

uint64_t remaining_length = unit.length >> DeltaHeadUnit::lenbits;
write_varint(buffer, remaining_length);

should be:

if (uint64_t remaining_length = unit.length >> DeltaHeadUnit::lenbits)
	write_varint(buffer, remaining_length);
#ifdef _WIN32
    output_fd = open(cvalue, O_RDWR | O_TRUNC | O_CREAT);
#else

should be (else eof added!):

#ifdef _WIN32
    output_fd = open(cvalue, O_RDWR | O_TRUNC | O_CREAT | O_BINARY);
#else
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant