Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insert explicit casts to calm compiler warnings for -Wsign-conversion #5591

Closed
wants to merge 1 commit into from

Conversation

mpsuzuki
Copy link
Contributor

@mpsuzuki mpsuzuki commented Jun 7, 2019

During compilation of the latest source, I received several warnings for -WSign-conversion. Here is a patch inserting explicit casts to calm them.

@michaelrsweet michaelrsweet self-assigned this Jun 10, 2019
@michaelrsweet michaelrsweet added this to the CUPS 2.3.x milestone Jun 10, 2019
@michaelrsweet
Copy link
Collaborator

Sigh... This is all because the newest GCC defaults to unsigned enums... Will consider for 2.3.x.

@mpsuzuki
Copy link
Contributor Author

I see. How about add "-Wno-sign-conversion" to CFLAGS as quick workaround?

@michaelrsweet
Copy link
Collaborator

@mpsuzuki The problem with -Wno-sign-conversion is that it also eliminates valid issues, like between size_t and ssize_t, that we want to see reported.

@michaelrsweet
Copy link
Collaborator

Merged mostly as-is...

[master 8ef4f50] Eliminate new GCC compiler warnings (Issue #5591)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants