Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken image in the Architecture documentation #184

Closed
kjc-stripe opened this issue Apr 19, 2018 · 3 comments
Closed

Broken image in the Architecture documentation #184

kjc-stripe opened this issue Apr 19, 2018 · 3 comments

Comments

@kjc-stripe
Copy link

https://apple.github.io/foundationdb/architecture.html

It appears you're trying to use a PDF in an image tag, which won't work. I've attached a PNG you can use on the page, which you can link to the PDF

architecture

@davelester
Copy link
Contributor

Thanks for reporting this, as well as attaching a PNG that we can use. LGTM!

Would you like to open a pull request, or have us commit it on your behalf?

@ajomadlabs
Copy link

Can I take this up ?

@alecgrieser
Copy link
Contributor

The fix for this, #194, has been merged, so I'm going to go ahead and close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants