docs(architecture.html): The architecture image was missing #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IDisposable
approved these changes
Apr 19, 2018
ringods
reviewed
Apr 20, 2018
| .. image:: /images/Architecture.png |
There was a problem hiding this comment.
Is the PNG also built by Sphinx? Just asking because the current images folder doesn't contain a PNG file:
https://github.com/apple/foundationdb/tree/master/documentation/sphinx/source/images
There was a problem hiding this comment.
no the png was extracted from the architecture.pdf and provided by @kjc-stripe
alecgrieser
approved these changes
Apr 23, 2018
This was referenced Apr 23, 2018
etschannen
added a commit
to etschannen/foundationdb
that referenced
this pull request
Mar 26, 2019
Fix valgrind errors
etschannen
pushed a commit
to etschannen/foundationdb
that referenced
this pull request
Mar 26, 2019
docs(architecture.html): The architecture image was missing
sfc-gh-tclinkenbeard
added a commit
that referenced
this pull request
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the broken image for #184