Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change README to instruct users to install OpenSSL, not LibreSSL #3022

Open
alexmiller-apple opened this issue Apr 24, 2020 · 1 comment
Open

Comments

@alexmiller-apple
Copy link
Contributor

The CI and builds were changed, and the code now depends on OpenSSL, and will not build with LibreSSL. Thus, we should update the README to have correct build instructions again.

@atn34
Copy link
Collaborator

atn34 commented Apr 25, 2020

We should also update cmake - currently it finds libressl, tries to build with TLS enabled, and then fails

/home/anoyes/workspace/foundationdb/flow/TLSConfig.actor.cpp:37:37: error: use of undeclared identifier 'OPENSSL_INIT_NO_ATEXIT'
                int success = OPENSSL_init_crypto(OPENSSL_INIT_NO_ATEXIT, nullptr);
                                                  ^
/home/anoyes/workspace/foundationdb/flow/TLSConfig.actor.cpp:49:2: error: use of undeclared identifier 'OPENSSL_cleanup'
        OPENSSL_cleanup();
        ^
2 errors generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants