Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the restored range in the actual restore #4568

Merged
merged 5 commits into from Mar 30, 2021

Conversation

jzhou77
Copy link
Contributor

@jzhou77 jzhou77 commented Mar 25, 2021

This change will use the actual restore range as the filter for choose files during the restore, which can significantly reduces the number of range files (by filtering based on ranges) being used. See the issue description in #4585.

Correctness passed 100k tests.
20210328-043707-jingyu_zhou-46d4c41ac5c7db7f compressed=True data_size=20363511 duration=3787745 ended=106739 fail_fast=10 max_runs=100000 pass=100001 priority=100 remaining=0 runtime=0:23:27 sanity=False started=106761 stopped=20210328-050034 submitted=20210328-043707 timeout=5400 username=jingyu_zhou

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or master if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@jzhou77 jzhou77 marked this pull request as ready for review March 28, 2021 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants