Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For the pkl CLI, please provide an installer package for Homebrew #13

Closed
ujay68 opened this issue Feb 3, 2024 · 9 comments
Closed

For the pkl CLI, please provide an installer package for Homebrew #13

ujay68 opened this issue Feb 3, 2024 · 9 comments

Comments

@ujay68
Copy link

ujay68 commented Feb 3, 2024

Subject says all.

Homebrew (https://brew.sh/) is a very popular package manager for macOS where you can find almost any tool you might ever want to install.

@stackoverflow
Copy link
Contributor

We already started the process of releasing Pkl to homebrew. Should come soon.

@bioball
Copy link
Contributor

bioball commented Feb 3, 2024

Submitted here: Homebrew/homebrew-core#161655

Looks like we need to re-submit as a cask.

@ujay68
Copy link
Author

ujay68 commented Feb 3, 2024

Great. Thank you!

@austinarbor
Copy link

I don't think cask is the right approach, something like the below should work

class Pkl < Formula
  desc "Configuration as code language with rich validation and tooling"
  homepage "https://pkl-lang.org"
  url "https://github.com/apple/pkl/archive/refs/tags/0.25.1.tar.gz"
  sha256 "f60412679a9a8a1740e81cbed89a3ca9ddc9aa2cf0c487ff8a8a9fce70c0bf4a"
  license "Apache-2.0"

  depends_on "openjdk@17" => :build

  def install
    ENV["JAVA_HOME"] = Formula["openjdk@17"].opt_prefix
    task_os = OS.mac? ? "mac" : "linux"
    task_arch = Hardware::CPU.arm? ? "Aarch64" : "Amd64"
    task_name = ":pkl-cli:#{task_os}Executable#{task_arch}"

    system "git", "apply", "patches/graalVm23.patch" if OS.mac? && Hardware::CPU.arm?

    system "./gradlew", task_name
    os = OS.mac? ? "macos" : "linux"
    arch = Hardware::CPU.arm? ? "aarch64" : "amd64"
    bin.install "pkl-cli/build/executable/pkl-#{os}-#{arch}" => "pkl"
  end
end

However, the problem I am having is with homebrew's shimmed cc. It is expecting the environment variable HOMEBREW_RUBY_PATH to be present, and something is wiping out that value in the task process before the cc invocation. I tried to see where it was getting removed from the environment but was unable to figure it out

@mattpackwood
Copy link

It looks like the submission has been stalled on the Homebrew side, is that the status?

@pavelzw
Copy link

pavelzw commented Feb 20, 2024

It looks like the submission has been stalled on the Homebrew side, is that the status?

there is a new submission Homebrew/homebrew-core#162857

@mattpackwood
Copy link

@pavelzw It looks like you (we) are just waiting for someone to approve the merge?

@bioball
Copy link
Contributor

bioball commented Feb 26, 2024

Yeah, right now we are waiting for a homebrew maintainer to approve and merge the PR.

@bioball
Copy link
Contributor

bioball commented Feb 29, 2024

This is now available on homebrew! brew install pkl will install the CLI.

We are adding instructions to our website in #270.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants