Provide JDK flow adapters #824 #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
3 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
@servicetalk-bot test this please |
NiteshKant
pushed a commit
to NiteshKant/servicetalk
that referenced
this pull request
Jan 2, 2020
__Motivation__ As part of reviewing apple#904 following issues were observed in `ReactiveStreamsAdapters`: - One method Javadoc had a typo linking to the wrong class. - Name of internal classes were not consistently indicating the intent. - Internal class `PublisherToRSPublisher` is redundant, we can instead use `PublisherSourceToRSPublisher` __Modification__ - Fixed javadoc - Renamed classes to follow [Rs, St]To[Rs, St][Publisher, Subscriber, Subscription] format - Inlined a variable in the test. __Result__ Better readability for `ReactiveStreamsAdapters`
NiteshKant
suggested changes
Jan 2, 2020
There was a problem hiding this comment.
Thanks @muthupalaniappan for the contribution.
I noticed some minor cosmetic issues with the reactive-streams adapter implementation for which I have created a PR #906 for your reference and have also marked the changes in this PR.
...talk-concurrent-jdkflow/src/main/java/io/servicetalk/concurrent/jdkflow/JdkFlowAdapters.java
Outdated
Show resolved
Hide resolved
...talk-concurrent-jdkflow/src/main/java/io/servicetalk/concurrent/jdkflow/JdkFlowAdapters.java
Outdated
Show resolved
Hide resolved
...talk-concurrent-jdkflow/src/main/java/io/servicetalk/concurrent/jdkflow/JdkFlowAdapters.java
Outdated
Show resolved
Hide resolved
...-concurrent-jdkflow/src/test/java/io/servicetalk/concurrent/jdkflow/JdkFlowAdaptersTest.java
Outdated
Show resolved
Hide resolved
...-concurrent-jdkflow/src/test/java/io/servicetalk/concurrent/jdkflow/JdkFlowAdaptersTest.java
Outdated
Show resolved
Hide resolved
...talk-concurrent-jdkflow/src/main/java/io/servicetalk/concurrent/jdkflow/JdkFlowAdapters.java
Outdated
Show resolved
Hide resolved
...talk-concurrent-jdkflow/src/main/java/io/servicetalk/concurrent/jdkflow/JdkFlowAdapters.java
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| private static final class FlowSubscriber<T> implements PublisherSource.Subscriber<T> { |
There was a problem hiding this comment.
nit: Rename to StToFlowSubscriber to match the other class names.
There was a problem hiding this comment.
This should then be FlowToStSubscriber
...talk-concurrent-jdkflow/src/main/java/io/servicetalk/concurrent/jdkflow/JdkFlowAdapters.java
Outdated
Show resolved
Hide resolved
.../src/test/java/io/servicetalk/concurrent/jdkflow/tck/AbstractCompletableOperatorTckTest.java
Outdated
Show resolved
Hide resolved
NiteshKant
pushed a commit
that referenced
this pull request
Jan 2, 2020
__Motivation__ As part of reviewing #904 following issues were observed in `ReactiveStreamsAdapters`: - One method Javadoc had a typo linking to the wrong class. - Name of internal classes were not consistently indicating the intent. - Internal class `PublisherToRSPublisher` is redundant, we can instead use `PublisherSourceToRSPublisher` __Modification__ - Fixed javadoc - Renamed classes to follow [Rs, St]To[Rs, St][Publisher, Subscriber, Subscription] format - Inlined a variable in the test. __Result__ Better readability for `ReactiveStreamsAdapters`
Motivation: For interoperability with JDK Flow today we dont have direct flow adapters, users have to use ReactiveStreams adapters and then use the Flow adapter provided by ReactiveStreams which is two step conversion and additional dependency on ReactiveStreams. Modifications: * Added a new module `servicetalk-concurrent-jdkflow` and applied `servicetalk-gradle-plugin-internal-library` * Since flow apis are available only from jdk 9 it gets little tricky here and have to deviate from the standards as below * Build the module only if jdk 9 or above is available during build * Override the source and target compatibility of the module to jdk9 * Added `JdkFlowAdapters` class in main similar to `ReactiveStreamsAdapters` * Added `JdkFlowAdaptersTest` and `reactive-streams-tck-flow` tests in test similar to `ReactiveStreamsAdaptersTest` and `reactive-streams-tck` tests Result: A new module servicetalk-concurrent-jdkflow is added which can be used with jdk9 and above for interoperability with JDK flow api. Fixes apple#824
Motivation: For interoperability with JDK Flow today we dont have direct flow adapters, users have to use ReactiveStreams adapters and then use the Flow adapter provided by ReactiveStreams which is two step conversion and additional dependency on ReactiveStreams. Modifications: * Added a new module `servicetalk-concurrent-jdkflow` and applied `servicetalk-gradle-plugin-internal-library` * Since flow apis are available only from jdk 9 it gets little tricky here and have to deviate from the standards as below * Build the module only if jdk 9 or above is available during build * Override the source and target compatibility of the module to jdk9 * Added `JdkFlowAdapters` class in main similar to `ReactiveStreamsAdapters` * Added `JdkFlowAdaptersTest` test class in test similar to `ReactiveStreamsAdaptersTest` test class Result: A new module servicetalk-concurrent-jdkflow is added which can be used with jdk9 and above for interoperability with JDK flow api. Fixes apple#824
muthupalaniappan
force-pushed
the
issue_824
branch
from
5ce1640
to
fc9bad2
Compare
|
@servicetalk-bot test this please |
NiteshKant
approved these changes
Jan 3, 2020
|
@muthupalaniappan can you also update the docs to reflect this change now? This is where you need to change: Under "Interoperability", modify the statement:
to
|
|
Thanks @NiteshKant , As you have already approved it should I make the doc change in a separate PR? |
|
@muthupalaniappan its ok to do the change in this PR, I can re-review |
Motivation: For interoperability with JDK Flow today we dont have direct flow adapters, users have to use ReactiveStreams adapters and then use the Flow adapter provided by ReactiveStreams which is two step conversion and additional dependency on ReactiveStreams. Modifications: * Added a new module `servicetalk-concurrent-jdkflow` and applied `servicetalk-gradle-plugin-internal-library` * Since flow apis are available only from jdk 9 it gets little tricky here and have to deviate from the standards as below * Build the module only if jdk 9 or above is available during build * Override the source and target compatibility of the module to jdk9 * Added `JdkFlowAdapters` class in main similar to `ReactiveStreamsAdapters` * Added `JdkFlowAdaptersTest` test class in test similar to `ReactiveStreamsAdaptersTest` test class Result: A new module servicetalk-concurrent-jdkflow is added which can be used with jdk9 and above for interoperability with JDK flow api. Fixes apple#824
|
@servicetalk-bot test this please |
NiteshKant
approved these changes
Jan 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
For interoperability with JDK Flow today we dont have direct flow adapters, users have to use ReactiveStreams adapters and then use the Flow adapter provided by ReactiveStreams which is two step conversion and additional dependency on ReactiveStreams.
Modifications:
servicetalk-concurrent-jdkflowand appliedservicetalk-gradle-plugin-internal-libraryJdkFlowAdaptersclass in main similar toReactiveStreamsAdaptersJdkFlowAdaptersTesttest class in test similar toReactiveStreamsAdaptersTesttest class.Result:
A new module servicetalk-concurrent-jdkflow is added which can be used with jdk9 and above for interoperability with JDK flow api.
Fixes #824