Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement NSArray's customMirror #2033

Merged
merged 4 commits into from
Mar 26, 2019
Merged

Implement NSArray's customMirror #2033

merged 4 commits into from
Mar 26, 2019

Conversation

noppefoxwolf
Copy link
Contributor

No description provided.

@noppefoxwolf noppefoxwolf changed the title Implement NSArray's customMirror [4.2] Implement NSArray's customMirror Mar 23, 2019
@ikesyo
Copy link
Member

ikesyo commented Mar 23, 2019

Let's kicking CI.

@swift-ci Please test.

@ikesyo
Copy link
Member

ikesyo commented Mar 23, 2019

@noppefoxwolf swift-4.2-branch is limited to pull requests for bug fixes which are already landed on master. Could you target this on master?

See https://forums.swift.org/t/announcing-swift-4-2-2-and-monthly-swift-4-2-x-dot-releases-for-linux/20148 for the details.

@noppefoxwolf noppefoxwolf changed the base branch from swift-4.2-branch to master March 23, 2019 04:20
@noppefoxwolf noppefoxwolf changed the title [4.2] Implement NSArray's customMirror Implement NSArray's customMirror Mar 23, 2019
@noppefoxwolf
Copy link
Contributor Author

@ikesyo Thank you for your comment!
I changed target and resolved conflict.

ikesyo
ikesyo reviewed Mar 23, 2019
View reviewed changes
Foundation/NSArray.swift Outdated Show resolved Hide resolved
TestFoundation/TestNSArray.swift Outdated Show resolved Hide resolved
@ikesyo
Copy link
Member

ikesyo commented Mar 23, 2019

@swift-ci Please test

@noppefoxwolf
Copy link
Contributor Author

@ikesyo Thank you!
I resolve comments issues.

@ikesyo
Copy link
Member

ikesyo commented Mar 23, 2019

@swift-ci Please test

1 similar comment
@spevans
Copy link
Contributor

spevans commented Mar 23, 2019

@swift-ci Please test

@noppefoxwolf
Copy link
Contributor Author

@ikesyo @spevans Thank you for checking.
Is there anything else to do?

ikesyo
ikesyo approved these changes Mar 25, 2019
View reviewed changes
Copy link
Member

@ikesyo ikesyo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were waiting for CI to be all-green and it's okay now 👍

@ikesyo
Copy link
Member

ikesyo commented Mar 25, 2019

@swift-ci test and merge

1 similar comment
@ikesyo
Copy link
Member

ikesyo commented Mar 26, 2019

@swift-ci test and merge

@swift-ci swift-ci merged commit 72e4427 into swiftlang:master Mar 26, 2019
@millenomi millenomi mentioned this pull request Apr 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikesyo ikesyo ikesyo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@noppefoxwolf @ikesyo @spevans @swift-ci