Foundation: update for BOOL bridging
#2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @gmittert @millenomi |
gmittert
reviewed
Apr 25, 2019
|
The rest of the boolean logic changes look equivalent to me. |
compnerd
force-pushed
the
a-bridge-too-far
branch
from
0d81ebb
to
7aaf8bf
Compare
|
Please test with the following PRs: @swift-ci please test |
Now that `BOOL` is bridged to `WindowsBOOL` and `Bool`, clean up the instances of `BOOL` values since they will no longer be available.
compnerd
force-pushed
the
a-bridge-too-far
branch
from
7aaf8bf
to
81b1063
Compare
|
Please test with the following PRs: @swift-ci please test |
1 similar comment
|
Please test with the following PRs: @swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
BOOLis bridged toWindowsBOOLandBool, clean up theinstances of
BOOLvalues since they will no longer be available.