Make NIST PublicKeys conform to Hashable
#176
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sajjon
commented
Apr 18, 2023
| @@ -88,6 +88,14 @@ extension P256 { | |||
| let pemDocument = ASN1.PEMDocument(type: "PUBLIC KEY", derBytes: self.derRepresentation) | |||
| return pemDocument.pemString | |||
| } | |||
|
|
|||
| public static func ==(lhs: Self, rhs: Self) -> Bool { | |||
There was a problem hiding this comment.
Equatable, Part of #174 but I was unable to create a diff between just this PR and the source branch of that PR.
Sajjon
commented
Apr 18, 2023
| @@ -94,6 +94,14 @@ extension ${CURVE} { | |||
| let pemDocument = ASN1.PEMDocument(type: "PUBLIC KEY", derBytes: self.derRepresentation) | |||
| return pemDocument.pemString | |||
| } | |||
|
|
|||
| public static func ==(lhs: Self, rhs: Self) -> Bool { | |||
There was a problem hiding this comment.
Equatable, Part of #174 but I was unable to create a diff between just this PR and the source branch of that PR.
Sajjon
commented
Apr 18, 2023
| @@ -453,6 +453,138 @@ class SignatureTests: XCTestCase { | |||
| let compressedX963Positive = Data(base64Encoded: "A+QHCXtGd5WWSQgp37FBPXMy+nnSwFK79QQD0ZeNMv7L")! | |||
| XCTAssertThrowsError(try P256.Signing.PublicKey(x963Representation: compressedX963Positive)) | |||
| } | |||
|
|
|||
|
|
|||
| func testP256SigningPublicKeyEquatable() throws { | |||
There was a problem hiding this comment.
Equatable, Part of #174 but I was unable to create a diff between just this PR and the source branch of that PR.
Lukasa
requested changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make ALL
NISTPublicKeys conform toHashableN.B. Merge open PR #174 first (or if #174 is closed, close this one too), since this PR builds on top of that.
Checklist
If you've made changes to
gybfiles.script/generate_boilerplate_files_with_gyband included updated generated files in a commit of this pull requestMotivation:
This is the
NISTanalogue counterpart of #175, so the motivation put in there applies here as well.This PR is an addition of open PR #174.
Modifications:
P256,P384andP521's Signing and KeyAgreementPublicKeybeHashable, by...NISTECPublicKeyto beHashableand addinghash:intofunction inECDH.swift.gybResult:
ALL NIST PublicKey's now conform to
Hashable