Make NIST PublicKey
s conform to Equatable
#174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make NIST PublicKey's (
P256
,P384
andP521
) conform toEquatable
Checklist
If you've made changes to
gyb
files.script/generate_boilerplate_files_with_gyb
and included updated generated files in a commit of this pull requestMotivation:
There is really no drawback in adding
Equatable
conformance, as argued in #173Modifications:
P256
,P384
andP521
's Signing and KeyAgreementPublicKey
beEquatable
, by...NISTECPublicKey
to beEquatable
and adding equals function inECDH.swift.gyb
Result:
ALL NIST PublicKey's now conform to
Equatable