Fix symbol link parsing bug for -(_:_:) operators with hash disambiguation
#739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-ronnqvist
changed the title
/(_:_:) operators with hash disambiguation
d-ronnqvist
changed the title
/(_:_:) operators with hash disambiguation -(_:_:) operators with hash disambiguation
|
@swift-ci please test |
patshaughnessy
approved these changes
Oct 25, 2023
d-ronnqvist
added a commit
to d-ronnqvist/swift-docc
that referenced
this pull request
Nov 10, 2023
…wiftlang#739) rdar://113870038 Co-authored-by: Pat Shaughnessy <pat_shaughnessy@apple.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: rdar://113870038
Summary
Fix a bug where path component names wasn't consistently parsed depending on if the path component had a hash disambiguation or not. This resulted in subtraction operators (
-(_:_:)) parsing as an empty name when the link had a hash disambiguation.Dependencies
None
Testing
Define a public type with
-(_:_:)operators, for example:Link to
MyNumber/-(_:_:)-abc123. After correcting the hash (which depends on the module name where this symbol is defined) link should resolve successfully.Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded[ ] Updated documentation if necessary