[5.10] Fix bugs with symbol links to /(_:_:) operators (#717)
#772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support escaping forward slash in symbol links rdar://112555102 * Support operators with "/" without escaping rdar://112555102 * Remove need to pass original link string to create error info * Replace "/" in symbol names with "_" in resolved topic references
|
@swift-ci please test |
franklinsch
approved these changes
Dec 14, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick of #717
Explanation: Fixes two bugs where operators with a "/" in the name couldn't be linked to and where their data files in the output archive could collide with other pages's data files.
Scope: Symbols with "/" in the name, for example
/(_:_:)and/=(_:_:).Issue: rdar://112555102
Risk: Low.
Testing: Added test, ran the existing tests, and manually tested in different scenarios.
Reviewer: @patshaughnessy