Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-11771] UseShorthandTypeNames doesn’t wrap function types in parentheses #344

Closed
swift-ci opened this issue Nov 13, 2019 · 4 comments
Closed

[SR-11771] UseShorthandTypeNames doesn’t wrap function types in parentheses #344

swift-ci opened this issue Nov 13, 2019 · 4 comments
Labels
bug Something isn't working swift-format

Comments

@swift-ci
Copy link

Previous ID SR-11771
Radar rdar://problem/57176570
Original Reporter SDGGiesbrecht (JIRA User)
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s swift-format
Labels Bug
Assignee dylansturg (JIRA)
Priority Medium

md5: 01c69c652d3706456bb342d10b911f73

Issue Description:

UseShorthandTypeNames ends up changing some types when it attempts to contract them:

Optional<(_ nestedInOptional: Bool) -> Void>?
↓
(_ nestedInOptional: Bool) -> Void??
@beccadax
Copy link

@swift-ci create

@swift-ci
Copy link
Author

Comment by Dylan Sturgeon (JIRA)

This looks fairly straightforward to fix, I can tackle it.

@swift-ci
Copy link
Author

Comment by Dylan Sturgeon (JIRA)

This should be fixed by #82. Let me know if you have any trouble!

@swift-ci
Copy link
Author

Comment by Jeremy David Giesbrecht (JIRA)

Yes. I saw that. Thanks.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from swiftlang/swift May 9, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working swift-format
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@beccadax @swift-ci