Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

take out metadata to start with and make opaque later #31

Closed
weissi opened this issue Mar 27, 2019 · 2 comments · Fixed by #36
Closed

take out metadata to start with and make opaque later #31

weissi opened this issue Mar 27, 2019 · 2 comments · Fixed by #36
Milestone

Comments

@weissi
Copy link
Member

weissi commented Mar 27, 2019

On the forums , a few have rightly pointed out that currently, there's two places to get/set the metadata:

logger[metdataKey: "foo"] = "bar"

and

logger.metadata["foo"] = "bar"

The intention is to always use the former (logger[metdataKey: "foo"] = "bar") unless you want to store/retrieve the whole metadata storage, for example for MDC.

But as it was correctly pointed out, if that's the case we could/should make it opaque.

My proposal for right now is that the LogHandlers need to support both but the Logger should only expose the subscript. In a new minor version that we can release anytime, we could then add a back a well-designed story for MDC and friends.

@weissi weissi added this to the 1.0.0 milestone Mar 27, 2019
@weissi
Copy link
Member Author

weissi commented Mar 27, 2019

CC @tomerd

@ktoso
Copy link
Member

ktoso commented Apr 8, 2019

Sounds good to rip our now and design on later.

For tracking the progress though, I think this ticket will be closed as the "rip out" part, so I'll open up the "design it" adding one of the use-cases, sounds good?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants