Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request -- extended auto links #134

Open
LiYanan2004 opened this issue Jul 3, 2023 · 3 comments
Open

Feature Request -- extended auto links #134

LiYanan2004 opened this issue Jul 3, 2023 · 3 comments

Comments

@LiYanan2004
Copy link

Extended Auto-link is not supported. Full info: https://github.github.com/gfm/#extended-www-autolink

I'm not sure whether this feature would be supported in the future.

@LiYanan2004
Copy link
Author

The parser is powered by GitHub-flavored Markdown's cmark-gfm implementation, so it follows the spec closely. As the needs of the community change, the effective dialect implemented by this library may change.

This project starts from 2021 and that GitHub Flavored Markdown Spec release at 2019. Not sure whether this feature has been removed for some purposes or has not been implemented so far.

@QuietMisdreavus
Copy link
Contributor

The behavior you've linked to is governed by the autolink extension, which Swift-Markdown does not (currently) enable:

https://github.com/apple/swift-markdown/blob/cb80ea4151e5860a3b344d46e14cbcb52c5daeb3/Sources/Markdown/Parser/CommonMarkConverter.swift#L603-L609

I have an old PR (#23) to allow arbitrary extensions and cmark options when doing Markdown conversion, but there's no guarantee that Swift-Markdown would be able to accommodate an extension that's not currently used (e.g. if it introduces a new kind of node). It's possible to add the autolink extension to this list and determine whether or not Swift-Markdown can handle it.

@LiYanan2004
Copy link
Author

LiYanan2004 commented Jul 4, 2023

Great Job @QuietMisdreavus. You may need to @somebody to fasten this process? Maybe reviewers forget to review your great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants