Add a subscript to HPACKHeaders to return the first value with a matc… #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
approved these changes
Dec 2, 2019
Sources/NIOHPACK/HPACKHeader.swift
Outdated
| /// | ||
| /// - Parameter name: The header field name whose first value should be retrieved. | ||
| /// - Returns: The first value for the header field name. | ||
| public subscript(first name: String) -> String? { |
There was a problem hiding this comment.
@weissi What are your thoughts about the spelling of this API? It sits a bit weirdly with me, but I don't know if it really matters.
There was a problem hiding this comment.
I think we should do something more similar to what the stdlib does for first(where:). What about first(name: String)?
There was a problem hiding this comment.
That's fine by me: the only risk is that this type already has a first(where:) so that API may get lost in the autocorrect.
There was a problem hiding this comment.
first(name:) sounds good to me too.
…hing name Motivation: In some cases you only expect (or care about) a single value for a header. However, getting this value without allocating an array or traversing the whole array requres using first(where:) provided by Sequence. This is not very ergonomic as it requires users to do the case-insensitive comparison and then exctact the value from the HPACKHeader. Additionally, users cannot use NIO HTTP/2s case insensitive ASCII comparison. Modifications: - Provide a first(name:) method on HPACKHeaders which returns the value from the first header whose name is a case insentive match of the subscript parameter. Result: It's easier to get the first
glbrntt
force-pushed
the
gb-headers-first
branch
from
c291d9c
to
8012942
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hing name
Motivation:
In some cases you only expect (or care about) a single value for a
header. However, getting this value without allocating an array or
traversing the whole array requres using first(where:) provided by
Sequence. This is not very ergonomic as it requires users to do the
case-insensitive comparison and then exctact the value from the
HPACKHeader. Additionally, users cannot use NIO HTTP/2s case insensitive
ASCII comparison.
Modifications:
first header whose name is a case insentive match of the subscript
parameter.
Result: