-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build_podspec script & added SwiftNIOHPACK Pod #185
Conversation
Can one of the admins verify this patch? |
5 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@swift-nio-bot test this please |
SwiftNIOHTTP2
has a dependency on internal targetSwiftNIOHPACK
so validating the podspec was failingSwiftNIOHTTP2.podspec
&SwiftNIOHPACK .podspec
NIOHTTP2StreamChannel.swift
, it importsNIOConcurrencyHelpers
which was not added as a dependency explicitly. Added the dependency which allowed the successful validation of theSwiftNIOHTTP2
Pod.Cocoapods
SwiftNIOHTTP2
SwiftNIOHPACK
Newly created Pods from Release 1.9.1 - still need to add the other maintainers as Pod owners!