ChannelPipeline H2 inline multiplexer conf funcs #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: To have parity with the legacy separate `HTTP2ChannelHandler`-`StreamMultiplexer` HTTP2 stream multiplexing model we provide channel pipelineconfiguration functions using the new inline multiplexer. Modifications: * New versions of `configureHTTP2Pipeline` and `configureCommonHTTPServerPipeline` which set up the pipeline using inline stream multiplexers * Tests targeting the new functions ported from `ConfiguringPipelineWithFramePayloadStreamsTests.swift` Result: New pipeline configuration conveniences for inline HTTP2 multiplexing are available.
rnro
force-pushed
the
ChannelPipeline_HTTP2_pipeline_configuration_functions_for_inline_multiplexer
branch
from
78863f8
to
ea28449
Compare
Lukasa
requested changes
Mar 30, 2023
| return self.configureHTTP2SecureUpgrade(h2ChannelConfigurator: h2ChannelConfigurator, | ||
| http1ChannelConfigurator: http1ChannelConfigurator) | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we find a way to deduplicate this with the older code?
There was a problem hiding this comment.
Yes! Somewhat. There is some duplicated code but I don't think we'd be able to save much by abstracting it away further.
Lukasa
approved these changes
Mar 30, 2023
rnro
deleted the
ChannelPipeline_HTTP2_pipeline_configuration_functions_for_inline_multiplexer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
To have parity with the legacy separate
HTTP2ChannelHandler-StreamMultiplexerHTTP2 stream multiplexing model we provide channel pipelineconfiguration functions using the new inline multiplexer.Modifications:
configureHTTP2PipelineandconfigureCommonHTTPServerPipelinewhich set up the pipeline using inline stream multiplexersConfiguringPipelineWithFramePayloadStreamsTests.swiftResult:
New pipeline configuration conveniences for inline HTTP2 multiplexing are available.