Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

understand and test IMAP String encoding #10

Closed
weissi opened this issue Mar 24, 2020 · 1 comment · Fixed by #282
Closed

understand and test IMAP String encoding #10

weissi opened this issue Mar 24, 2020 · 1 comment · Fixed by #282

Comments

@weissi
Copy link
Member

weissi commented Mar 24, 2020

Currently, we’re just handing through the raw bytes but IMAP does have some charset support and also there’s some UTF-7 (not a typo) stuff in the spec.

We need to understand which things in IMAP are fundamentally Strings (and therefore need decoding with the correct charset) and which things are raw bytes.

@weissi weissi added the imap label Mar 30, 2020
@weissi weissi changed the title IMAP: understand and test IMAP String encoding understand and test IMAP String encoding Mar 30, 2020
@weissi
Copy link
Member Author

weissi commented Apr 23, 2020

Note (thanks @danieleggert) that we MUST NOT decode MailboxName into a String or at least we need to preserve the ByteBuffer and surface it to the user. The reason (again thanks @danieleggert) is that the actual identifier for a mailbox is its names as raw bytes, so IIUC, in theory we could have two mailboxes called "Föö" one encoded as UTF7, the other one as UTF8. Doesn't make much sense of course but in theory it exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant