Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parseCommandStream hack #62

Closed
weissi opened this issue Apr 20, 2020 · 2 comments
Closed

Remove parseCommandStream hack #62

weissi opened this issue Apr 20, 2020 · 2 comments

Comments

@weissi
Copy link
Member

weissi commented Apr 20, 2020

this needs to be implemented

        public mutating func parseCommandStream(buffer: inout ByteBuffer) throws -> NIOIMAP.CommandStream? {
            // TODO: SynchronisingLiteralParser should be added here but currently we don't have a place to return
            // the necessary continuations.

The right return type gives us the following information:

  • CommandStream?: a parsed command if enough data
  • number of continue requests to send
@weissi weissi added the imap label Apr 20, 2020
@Davidde94
Copy link
Collaborator

@weissi this has been resolved if I'm not mistaken?

@weissi
Copy link
Member Author

weissi commented May 28, 2020

you are not, thank you!

@weissi weissi closed this as completed May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants