prevent duplicate targets: rename NIOHTTP1Client to NIOSSLHTTP1Client #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: With package editing this problem surfaces: ``` $ jw-swift-5.0 swift test error: multiple products named 'NIOHTTP1Client' in: swift-nio, swift-nio-ssl error: multiple targets named 'NIOHTTP1Client' in: swift-nio, swift-nio-ssl ``` which is bad. Fortunately, these are executable targets that we can rename. Modification: rename `NIOHTTP1Client` in swift-nio-ssl to `NIOSSLHTTP1Client` Result: usable with package editing.
Lukasa
approved these changes
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
With package editing this problem surfaces:
which is bad. Fortunately, these are executable targets that we can
rename.
Modification:
rename
NIOHTTP1Clientin swift-nio-ssl toNIOSSLHTTP1ClientResult:
usable with package editing.