Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose multicast service type #165

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Expose multicast service type #165

merged 1 commit into from
Nov 9, 2022

Conversation

Lukasa
Copy link
Collaborator

@Lukasa Lukasa commented Nov 8, 2022

Motivation

As we've rolled out support for multicast on Linux, it makes sense to add equivalent configuration for swift-nio-transport-services. The two features aren't one-to-one, as Network.framework has substantially more capability than the Linux functionality.

Modifications

  • Expose a multipathServiceType channel option
  • Add a test to confirm we use it properly

Result

Multicast service types are available.

Motivation

As we've rolled out support for multicast on Linux, it makes sense to
add equivalent configuration for swift-nio-transport-services. The two
features aren't one-to-one, as Network.framework has substantially more
capability than the Linux functionality.

Modifications

- Expose a multipathServiceType channel option
- Add a test to confirm we use it properly

Result

Multicast service types are available.
@Lukasa Lukasa added the semver/minor Adds new public API. label Nov 8, 2022
Copy link
Contributor

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lukasa Lukasa merged commit e676b1f into apple:main Nov 9, 2022
@Lukasa Lukasa deleted the cb-multicast branch November 9, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/minor Adds new public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants