Pass Channels down pipeline not NWConnection #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weissi
requested changes
May 22, 2019
|
Pfft, fine. 😆 |
Motivation: The expectation is that server channels use Channel as their data type, but the initial data type in NIOTSListenerChannel was actually NWConnection. This is unnecessary and it makes it hard to interop between NIOTS and NIO. Modifications: - Initialize the NIOTSConnectionChannel in the NIOTSListenerChannel instead of in AcceptHandler. - Added some missing @available annotations in the tests. Result: More consistency
Lukasa
force-pushed
the
cb-channel-is-a-thing
branch
from
b37433c
to
132eb93
Compare
|
Ok, test added that inserts something into the server channel initializer that expects a channel instead of an NWConnection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The expectation is that server channels use Channel as their data type,
but the initial data type in NIOTSListenerChannel was actually
NWConnection. This is unnecessary and it makes it hard to interop
between NIOTS and NIO.
Modifications:
instead of in AcceptHandler.
Result:
More consistency
Resolves #44.