Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider making ThreadSpecificVariable public #61

Closed
weissi opened this issue Mar 2, 2018 · 3 comments
Closed

consider making ThreadSpecificVariable public #61

weissi opened this issue Mar 2, 2018 · 3 comments
Labels
discussion for things that need discussion enhancement New feature or request
Milestone
1.1.0

Comments

@weissi
Copy link
Member

weissi commented Mar 2, 2018

We should consider making ThreadSpecificVariable public.
Related to #60 (consider having an API to allow attaching metadata to an EventLoop)
@weissi weissi added enhancement New feature or request discussion for things that need discussion labels Mar 2, 2018
@normanmaurer normanmaurer mentioned this issue Mar 3, 2018
Closed
@normanmaurer
Copy link
Member

@Lukasa are you cool with this change ? If so I will make it happen

@Lukasa
Copy link
Contributor

Lukasa commented Mar 5, 2018

Yeah, I'm happy enough to do that.

normanmaurer added a commit to normanmaurer/swift-nio that referenced this issue Mar 5, 2018
@normanmaurer
Declare ThreadSpecificVariable public
9d2cdb1 
Motivation:

It's often useful for users to be able to store a thread-specific value (and so also EventLoop specific). We have ThreadSpecificVariable for this which was internal.

Modifications:

Change ThreadSpecificVariable to be public.

Result:

Fixes [apple#61].
@normanmaurer normanmaurer mentioned this issue Mar 5, 2018
Merged
Lukasa pushed a commit that referenced this issue Mar 5, 2018
@normanmaurer @Lukasa
Declare ThreadSpecificVariable public (#102)
784c5a7 
Motivation:

It's often useful for users to be able to store a thread-specific value (and so also EventLoop specific). We have ThreadSpecificVariable for this which was internal.

Modifications:

Change ThreadSpecificVariable to be public.

Result:

Fixes [#61].
@normanmaurer normanmaurer added this to the 1.1.0 milestone Mar 5, 2018
@normanmaurer
Copy link
Member

Was merged...

weissi pushed a commit to weissi/swift-nio that referenced this issue Jun 13, 2020
@glbrntt @Lukasa
Ensure preamble only gets sent once. (apple#61)
348a10e 
Motivation:

In certain cases it was possible for preamble to be sent once; this
would lead to frames getting sent more than once which in turn would
break state machines.

Modifications:

- Check the state of the connection before sending preamble.
- Include a test to check.

Result:

More correct implementation
weissi pushed a commit to weissi/swift-nio that referenced this issue Feb 4, 2023
@Lukasa @weissi
Clean up now-unnecessary warnings. (apple#61)
11b78f6 
Motivation:

As we bumped the dependency of NIO to 1.12, we can now avoid some
deprecation warnings, as even the low-end of NIO versions we
support will be safe.

While we're here, we can remove the warnings that Swift 5 started
emitting for our visibility specifiers in extensions.

Modifications:

- Replaced changeCapacity with reserveCapacity
- Replaced numThreads with numberOfThreads
- Removed redundant visibility specifiers

Result:

Back to warning free compilation.
rnro pushed a commit to rnro/swift-nio that referenced this issue Oct 3, 2023
@nlevitt
Flush error response output. Fixes apple#61 (apple#62)
38778e4
weissi pushed a commit to weissi/swift-nio that referenced this issue Feb 3, 2024
@artemredkin @weissi
fix NIO 2.9.0 deprecations (apple#61)
ed97628 
Motivation:

Usage of deprecated methods is bad.

Modification:

Fix usage of deprecated methods.

Result:

Fewer warnings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion for things that need discussion enhancement New feature or request
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
3 participants
@normanmaurer @weissi @Lukasa