Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alloc test: don't delete tmpdir #1026

Merged
merged 1 commit into from Jun 5, 2019

Conversation

Projects
None yet
2 participants
@weissi
Copy link
Member

commented Jun 4, 2019

Motivation:

The allocation tests shouldn't delete their working directory because
that's where you would navigate to debug them. Usually, they're run
through the integration tests which automatically clean up anyway.

Modifications:

Don't delete work dir

Result:

Easier to debug

alloc test: don't delete tmpdir
Motivation:

The allocation tests shouldn't delete their working directory because
that's where you would navigate to debug them. Usually, they're run
through the integration tests which automatically clean up anyway.

Modifications:

Don't delete work dir

Result:

Easier to debug

@weissi weissi requested a review from Lukasa Jun 4, 2019

@Lukasa Lukasa added this to the 2.3.0 milestone Jun 4, 2019

@Lukasa

Lukasa approved these changes Jun 4, 2019

@Lukasa Lukasa merged commit a04da61 into apple:master Jun 5, 2019

2 checks passed

pull request validation (5.0) Build finished.
Details
pull request validation (5.1) Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.