Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test pr to see if the API breakage checker works #1072

Closed
wants to merge 2 commits into from
Closed

Conversation

tomerd
Copy link
Member

@tomerd tomerd commented Jul 17, 2019

deliberately breaking the public API to see if the tooling works.

@tomerd
Copy link
Member Author

tomerd commented Jul 17, 2019

@swift-nio-bot test this please

1 similar comment
@tomerd
Copy link
Member Author

tomerd commented Jul 17, 2019

@swift-nio-bot test this please

@weissi
Copy link
Member

weissi commented Jul 17, 2019

@tomer you're the best. This is awesome!!

From the CI log of the failing build (CC @Lukasa / @normanmaurer ):

03:15:42 Checking _NIO1APIShims.json... OK
03:15:42 Checking NIOConcurrencyHelpers.json... OK
03:15:42 Checking NIOFoundationCompat.json... OK
03:15:42 Checking NIOHTTP1.json... OK
03:15:42 Checking NIO.json... OK
03:15:43 Checking NIOTestUtils.json... OK
03:15:43 Checking NIOTLS.json... OK
03:15:43 Checking NIOWebSocket.json... ERROR
03:15:43 ==============================
03:15:43 ERROR: public API change in NIOWebSocket.json
03:15:43 ==============================
03:15:43 
03:15:43 /* Generic Signature Changes */
03:15:43 
03:15:43 /* RawRepresentable Changes */
03:15:43 
03:15:43 /* Removed Decls */
03:15:43 EnumElement WebSocketErrorCode.unexpectedServerError has been removed
03:15:43 
03:15:43 /* Moved Decls */
03:15:43 
03:15:43 /* Renamed Decls */
03:15:43 
03:15:43 /* Type Changes */
03:15:43 
03:15:43 /* Decl Attribute changes */
03:15:43 
03:15:43 /* Fixed-layout Type Changes */
03:15:43 
03:15:43 /* Protocol Conformance Change */
03:15:43 
03:15:43 /* Protocol Requirement Change */
03:15:43 
03:15:43 /* Class Inheritance Change */
03:15:43 done

it totally noticed the API breakage :)

Also CC @xwu, this is really cool

@weissi weissi changed the title test pr test pr to see if the API breakage checker works Jul 17, 2019
@weissi weissi closed this Jul 25, 2019
@tomerd tomerd deleted the tomerd-patch-1 branch September 20, 2019 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants