ByteBuffer: make getInteger for UInt8 faster #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weissi
force-pushed
the
jw-bb-view-iterator-faster
branch
2 times, most recently
from
2bedbb9
to
c320d77
Compare
Lukasa
approved these changes
Feb 4, 2020
glbrntt
reviewed
Feb 4, 2020
Motivation: getInteger used the normal, generic implementation for UInt8s, however they can be made considerably faster by using a specialised method. ByteBufferIterator was also affected by this. Modifications: Use a specialised version for UInt8s for getInteger. Result: - ByteBufferView can be iterated about 20% faster.
weissi
force-pushed
the
jw-bb-view-iterator-faster
branch
from
79cf932
to
8758370
Compare
glbrntt
approved these changes
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
getInteger used the normal, generic implementation for UInt8s, however
they can be made considerably faster by using a specialised method.
ByteBufferIterator was also affected by this.
Modifications:
Use a specialised version for UInt8s for getInteger.
Result: