don't use _Nonnull for clang 3.6 (#147) #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Clang 3.6 doesn't know about `_Nonnull` which breaks compilation for our C atomics. Modifications: Defined `_Nonnull` as `__attribute__((nonnull))` which seems to already be available before clang 3.7. Result: NIO compiles with clang 3.6 as the default C compiler.
Closed
normanmaurer
added
the
patch-version-bump-only
normanmaurer
approved these changes
Mar 14, 2018
tiagomartinho
pushed a commit
to tiagomartinho/swift-nio
that referenced
this pull request
Mar 17, 2018
Motivation: Clang 3.6 doesn't know about `_Nonnull` which breaks compilation for our C atomics. Modifications: Defined `_Nonnull` as `__attribute__((nonnull))` which seems to already be available before clang 3.7. Result: NIO compiles with clang 3.6 as the default C compiler.
weissi
added a commit
to weissi/swift-nio
that referenced
this pull request
Jun 13, 2020
weissi
pushed a commit
to weissi/swift-nio
that referenced
this pull request
Feb 3, 2024
As outlined in a [Swift forums post in November ’21](https://forums.swift.org/t/swiftnio-swift-version-support/53232), SwiftNIO will only support the latest non-patch Swift release and the 2 immediately prior non-patch versions. - drop support for Swift 5.2 and 5.3. - update CI for Swift 5.4 to run on bionic instead of focal to ensure that we still test bionic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Clang 3.6 doesn't know about
_Nonnullwhich breaks compilation for ourC atomics.
Modifications:
Defined
_Nonnullas__attribute__((nonnull))which seems to alreadybe available before clang 3.7.
Result:
NIO compiles with clang 3.6 as the default C compiler.