Add benchmarks for copying BBV to Array. #2037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
added
the
needs-no-version-bump
fabianfett
reviewed
Feb 3, 2022
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| import Foundation |
There was a problem hiding this comment.
NIT: Do we need Foundation here?
fabianfett
approved these changes
Feb 3, 2022
Lukasa
force-pushed
the
cb-test-copying-bbv-to-array
branch
from
c97159b
to
cff9e74
Compare
glbrntt
reviewed
Feb 3, 2022
|
|
||
| for _ in 0..<1_000 { | ||
| var copy = Array(data) | ||
| count &+= copy.readableBytes |
Motivation: Protocols like Sequence have "private" hooks that can be implemented to provide fast-paths for some operations. We missed a few on BBV, and I'd like to add them. This is one use-case where they can help. Modifications: - Add an allocation-counter benchmark and a runtime benchmark for copying BBV to Array. Result: We have some benchmarks.
Lukasa
force-pushed
the
cb-test-copying-bbv-to-array
branch
from
cff9e74
to
4e9c5ae
Compare
glbrntt
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Protocols like Sequence have "private" hooks that can be implemented to
provide fast-paths for some operations. We missed a few on BBV, and I'd
like to add them. This is one use-case where they can help.
Modifications:
copying BBV to Array.
Result:
We have some benchmarks.