Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark for BBV contains. (#1385) #2042

Merged
merged 4 commits into from
Feb 9, 2022
Merged

Conversation

SeJV
Copy link
Contributor

@SeJV SeJV commented Feb 8, 2022

Add benchmark for BBV contains. (#1385)

Motivation:

Protocols like Sequence have "private" hooks that can be implemented to
provide fast-paths for some operations (similar to #2037). This is the benchmark in order to test a _customContainsEquatableElement implementation difference on performance.

Modifications:

  • Add BBV contains function call benchmark.

Result:

A new benchmark for BBV contains.

@swift-server-bot
Copy link

Can one of the admins verify this patch?

12 similar comments
@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, this looks great!

@Lukasa
Copy link
Contributor

Lukasa commented Feb 9, 2022

@swift-nio-bot test this please

@Lukasa Lukasa enabled auto-merge (squash) February 9, 2022 05:35
@Lukasa Lukasa merged commit 7000510 into apple:main Feb 9, 2022
@SeJV SeJV deleted the AddPerformanceTest branch February 9, 2022 07:17
@dnadoba dnadoba added patch-version-bump-only For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1) needs-no-version-bump For PRs that when merged do not need a bump in version number. and removed patch-version-bump-only For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1) labels Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-no-version-bump For PRs that when merged do not need a bump in version number.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants