ByteBuffer: deal correctly with underreporting ContiguousCollections #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weissi
force-pushed
the
jw-underreporting-cc
branch
2 times, most recently
from
02d0efa
to
073ff4e
Compare
|
@swift-nio-bot test this please |
Lukasa
added
the
patch-version-bump-only
Motivation: ContiguousCollections shouldn't give access to more than `count` bytes via `withUnsafeBytes` but if they do we should still handle this correctly and only copy `count` bytes. Modifications: - copy an upper limit of `count` bytes - fail hard if `withUnsafeBytes` offers fewer bytes as we can't do anything sensible then. Result: even illegal `ContiguousCollection` implementations don't cause issues.
weissi
force-pushed
the
jw-underreporting-cc
branch
from
073ff4e
to
e0d3571
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
ContiguousCollections shouldn't give access to more than
countbytesvia
withUnsafeBytesbut if they do we should still handle thiscorrectly and only copy
countbytes.Modifications:
countbyteswithUnsafeBytesoffers fewer bytes as we can't doanything sensible then.
Result:
even illegal
ContiguousCollectionimplementations don't cause issues.