Fix typo for Bootstrap’s resolver parameter #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
test this please |
normanmaurer
approved these changes
Mar 1, 2018
|
@swift-nio-bot test this please |
weissi
added
the
patch-version-bump-only
|
that's the flaky test addressed by #41 , so I'll retest |
|
test this please |
|
The failure is related to #45 and not this change. Let me merge this one |
|
@SebastianThiebaud thanks a lot! |
weissi
pushed a commit
to weissi/swift-nio
that referenced
this pull request
Feb 4, 2023
Motivation:
While working on an unwrapping patch, I wrote a few tests to provide an
envelope on the unwrapping behaviour in OpenSSL. Some of these tests
should have counterparts for closure, but do not. This patch brings the
equivalent tests forward.
Modifications:
- Tested the failure mode when receiving gibberish instead of
CLOSE_NOTIFY.
- Tested what happens to writes that are flushed after close().
Result:
Better test coverage.
rnro
pushed a commit
to rnro/swift-nio
that referenced
this pull request
Oct 3, 2023
Just to show that a) integration tests are useful (found a bug: assertion in handlerRemoved instead of deinit) b) integration tests are lots of work Co-authored-by: Johannes Weiss <johannes@jweiss.io>
weissi
added a commit
to weissi/swift-nio
that referenced
this pull request
Feb 3, 2024
Motivation: JSPN-RPC uses various framing methods, one is Content-Length based framing. NIOExtras should provide encoder/decoders for this. Modifications: Add such codecs. Result: NIOExtras more useful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.