Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in comments of EchoServer example #583

Merged
merged 1 commit into from Aug 18, 2018
Merged

Typo in comments of EchoServer example #583

merged 1 commit into from Aug 18, 2018

Conversation

imcotton
Copy link
Contributor

Fix typo in comments of the EchoServer example

@swift-nio-bot
Copy link

Can one of the admins verify this patch?

1 similar comment
@swift-nio-bot
Copy link

Can one of the admins verify this patch?

Lukasa
Lukasa approved these changes Aug 18, 2018
View reviewed changes
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Lukasa
Copy link
Contributor

Lukasa commented Aug 18, 2018

@swift-nio-bot test this please

@Lukasa Lukasa merged commit ee52d76 into apple:master Aug 18, 2018
@weissi weissi added this to the 1.10.0 milestone Aug 24, 2018
@weissi weissi added the patch-version-bump-only For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1) label Aug 24, 2018
@weissi weissi modified the milestones: 1.10.0, 1.9.3 Aug 28, 2018
weissi pushed a commit that referenced this pull request Aug 29, 2018
@imcotton @weissi
Typo in EchoServer example (#583)
5510d6c 
Motivation:

Explain here the context, and why you're making that change.
What is the problem you're trying to solve.

Modifications:

Describe the modifications you've done.

Result:

After your change, what will change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

Assignees
No one assigned
Labels
patch-version-bump-only For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1)
Projects
None yet
Milestone
1.9.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@imcotton @swift-nio-bot @Lukasa @weissi