CI: use DEVELOPMENT-SNAPSHOT-2019-01-23-a #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weissi
added
the
patch-version-bump-only
|
Woop CI failure. |
|
Huh, negative amount of remaining allocations, will investigate 🤣 |
weissi
force-pushed
the
jw-DEVELOPMENT-SNAPSHOT-2019-01-23-a
branch
from
d8abe26
to
86bd77b
Compare
|
yaay, @Lukasa the inliner threshold must have changed, but now it finally passes 🙌 |
weissi
commented
Jan 25, 2019
| @@ -74,6 +74,9 @@ private func writeTrailers(wrapOutboundOut: (IOData) -> NIOAny, ctx: ChannelHand | |||
| } | |||
| } | |||
|
|
|||
| // starting about swift-5.0-DEVELOPMENT-SNAPSHOT-2019-01-20-a, this doesn't get automatically inlined, which costs | |||
| // 2 extra allocations so we need to help the optimiser out. | |||
| @inline(__always) | |||
There was a problem hiding this comment.
@eeckstein between swift-5.0-DEVELOPMENT-SNAPSHOT-2019-01-13-a and swift-5.0-DEVELOPMENT-SNAPSHOT-2019-01-20-a this suddenly didn't get inlined anymore without any code changes.
Is that expected? It was stable from at least Swift 4.0.1 until now and then suddenly last week it broke...
There was a problem hiding this comment.
and thanks again @aschwaighofer for apple/swift#21933 which will make debugging that sort of thing unnecessary in the future :)
weissi
force-pushed
the
jw-DEVELOPMENT-SNAPSHOT-2019-01-23-a
branch
from
86bd77b
to
83479ca
Compare
Lukasa
approved these changes
Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Newer Swift versions are good and we should test them, this one threw a few curveballs at us:
posix_memalignwhich needed fixing in our alloc tests (fixed in alloc tests: hook posix_memalign & reallocf #782)Modifications
@inline(__always)to help the optimiserResult: