Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-13792] Index store should relate appendInterpolation from string literals #56189

Open
swift-ci opened this issue Oct 29, 2020 · 3 comments · May be fixed by #38900
Open

[SR-13792] Index store should relate appendInterpolation from string literals #56189

swift-ci opened this issue Oct 29, 2020 · 3 comments · May be fixed by #38900
Labels
expressions Feature: expressions feature A feature request or implementation indexing Area → source tooling: AST indexing interpolated strings Feature → expressions → literals → string literals: interpolated strings literals Feature → expressions: Literals such as an integer or string literal source tooling Area: IDE support, SourceKit, and other source tooling string literals Feature → expressions → literals: String literals String Area → standard library: The `String` type swift 5.9

Comments

@swift-ci
Copy link
Contributor

Previous ID SR-13792
Radar rdar://problem/70820224
Original Reporter Leitch (JIRA User)
Type New Feature
Additional Detail from JIRA
Votes 0
Component/s Source Tooling
Labels New Feature
Assignee Leitch (JIRA)
Priority Medium

md5: 0896b2e76fc58c37c42a995dde600eea

Issue Description:

Given the following code:

extension String.StringInterpolation {
    mutating func appendInterpolation(test value: Int) {
        appendInterpolation(value)
    }
}

public struct Fixture112 {
    public func someFunc() {
        print("test: \(test: 1)")
    }
}

The index store could include a relation from the someFunc() occurrence to appendInterpolation(test:). For the purposes of identifying unused code, it's not currently possible to identify that appendInterpolation(test:) is used in the string interpolation.
@swift-ci
Copy link
Contributor Author

Comment by Ian Leitch (JIRA)

/cc @benlangmuir

@benlangmuir
Copy link
Contributor

@swift-ci create

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@keith keith mentioned this issue May 25, 2023
Open
@keith
Copy link
Member

keith commented May 26, 2023

seems to still be the case at ed3555a

@keith keith added new feature indexing Area → source tooling: AST indexing and removed new feature labels May 26, 2023
@AnthonyLatsis AnthonyLatsis added feature A feature request or implementation source tooling Area: IDE support, SourceKit, and other source tooling String Area → standard library: The `String` type interpolated strings Feature → expressions → literals → string literals: interpolated strings literals Feature → expressions: Literals such as an integer or string literal expressions Feature: expressions swift 5.9 string literals Feature → expressions → literals: String literals labels May 27, 2023
@AnthonyLatsis AnthonyLatsis linked a pull request Nov 8, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
expressions Feature: expressions feature A feature request or implementation indexing Area → source tooling: AST indexing interpolated strings Feature → expressions → literals → string literals: interpolated strings literals Feature → expressions: Literals such as an integer or string literal source tooling Area: IDE support, SourceKit, and other source tooling string literals Feature → expressions → literals: String literals String Area → standard library: The `String` type swift 5.9
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Index] Walk implicit DeclRefExpr with an explicit ValueDecl. ileitch/swift
4 participants
@keith @benlangmuir @swift-ci @AnthonyLatsis