#if targetEnvironment(simulator) #12964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
DougGregor
approved these changes
Nov 17, 2017
| @@ -1503,6 +1503,9 @@ ERROR(empty_version_string,none, | |||
| WARNING(unknown_platform_condition_argument,none, | |||
| "unknown %0 for build configuration '%1'", | |||
| (StringRef, StringRef)) | |||
| WARNING(likely_simulator_platform_condition,none, | |||
| "plaform condition appears to be testing for simulator environment", | |||
There was a problem hiding this comment.
Could you tack on "; use 'targetEnvironment(simulator)' instead" ? That way, one doesn't have to look at the contents of the Fix-It to see what the fix is.
| @@ -254,6 +262,13 @@ std::pair<bool, bool> LangOptions::setTarget(llvm::Triple triple) { | |||
| else | |||
| addPlatformConditionValue(PlatformConditionKind::Runtime, "_Native"); | |||
|
|
|||
| // Set the "targetEnvironment" platform condition if targeting a simulator | |||
| // environmet. Otherwise _no_ value is present for targetEnvironment; it's | |||
graydon
changed the title
graydon
force-pushed
the
if-target-environment
branch
from
81cc50b
to
94988a2
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
compnerd
reviewed
Nov 29, 2017
| /// Get the identifier string from an \c Expr if it's an | ||
| /// \c UnresolvedDeclRefExpr, otherwise the empty string. | ||
| static StringRef getDeclRefStr(Expr *E) { | ||
| if (auto *UDRE = cast<UnresolvedDeclRefExpr>(E)) { |
There was a problem hiding this comment.
Am I just mistaken, or shouldn't this be a dyn_cast? cast implies that this must succeed and will abort if the expression type is not a UnresolvedDeclRefExpr.
There was a problem hiding this comment.
Oh, yes, this is a typo, thanks! Will fix tomorrow.
graydon
added a commit
to graydon/swift
that referenced
this pull request
Nov 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of swiftlang/swift-evolution#764 which has now been accepted. It is ready to merge.