Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gardening][Parse] Dead code elimination #5041

Merged
merged 1 commit into from
Sep 29, 2016

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Sep 28, 2016

Remove two conditional statements.

@rintaro
Copy link
Member Author

rintaro commented Sep 28, 2016

@swift-ci Please smoke test

@rintaro
Copy link
Member Author

rintaro commented Sep 28, 2016

@swift-ci Please smoke test Linux

@rintaro
Copy link
Member Author

rintaro commented Sep 28, 2016

First try:
@ddunbar Have you ever seen this?

******************** TEST 'llbuild :: BuildSystem/Build/missing-inputs.llbuild' FAILED ********************
...
inputs.llbuild:12:18: error: expected string not found in input
# CHECK-FAILURE: missing input 'input' and no rule to build it
                 ^
/home/buildnode/jenkins/workspace/swift-PR-Linux-smoke-test/branch-master/buildbot_linux/llbuild-linux-x86_64/tests/BuildSystem/Build/Output/missing-inputs.llbuild.tmp.out:1:1: note: scanning from here
/bin/sh -c true
^
/home/buildnode/jenkins/workspace/swift-PR-Linux-smoke-test/branch-master/buildbot_linux/llbuild-linux-x86_64/tests/BuildSystem/Build/Output/missing-inputs.llbuild.tmp.out:4:26: note: possible intended match here
<unknown>:0: error: cannot build 'output-1' due to missing input
                         ^

Second try: 😞

TestFoundation/TestNSURLSession.swift:40: error: TestURLSession.test_dataTaskWithURL : Asynchronous wait failed - Exceeded timeout of 12.0 seconds, with unfulfilled expectations: data task
TestFoundation/TestNSURLSession.swift:42: error: TestURLSession.test_dataTaskWithURL : XCTAssertEqual failed: ("unknown") is not equal to ("Kathmandu") - test_dataTaskWithURLRequest returned an unexpected result

@rintaro
Copy link
Member Author

rintaro commented Sep 28, 2016

@swift-ci Please smoke test Linux

@DougGregor
Copy link
Member

Good find, thanks!

@ddunbar
Copy link
Contributor

ddunbar commented Sep 28, 2016

@rintaro nope, I haven't. Worth a JIRA and you can put it on me.

@rintaro rintaro merged commit 07e66a4 into swiftlang:master Sep 29, 2016
@rintaro rintaro deleted the deadcode-parsebraceitems branch September 29, 2016 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants