[5.8] IRGen: Don't directly call async functions that have weak/linkonce_odr linkage #65254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce_odr linkage The async function pointer context size and the async function implementiation are logically tied. Using a different async context pointer context size and async function implementation (from different translation units) is problematic. rdar://106029807 Original PR: apple#64638 Fixes an issue when linking static libraries/object files from different TU with the same async function pointer name put different context values.
|
@swift-ci test |
|
@swift-ci test macOS |
|
macOS CI for the 5.8 release branch was broken, should be fixed now, apple/swift-package-manager#6458. |
|
@swift-ci test macOS |
airspeedswift
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The async function pointer context size and the async function implementiation are logically tied. Using a different async context pointer context size and async function implementation (from different translation units) is problematic.
rdar://106029807
Original PR: #64638
Fixes an issue when linking static libraries/object files from different TU with the same async function pointer name put different context values.