[wasm] Repair IRGen/async.swift test #71754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test has been crashed with WebAssembly target due to lack of tail-call support guard in the CoroSplit llvm pass. The crash has been fixed by llvm/llvm-project@8c5c4d9 but the new codegen produces slightly different IR (`call` instead of `tail call`, while they are lowered to the same wasm instruction). So this patch adds new checks for wasm target.
|
preset=buildbot_linux_crosscompile_wasm |
|
@swift-ci Please smoke test |
kateinoigakukun
deleted the
pr-e2b725c98aa1ec0fb01b5e6da0ee4fcc3d327c44
branch
|
The failure on wasm CI was another unrelated issue and it's fixed by #71772 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test has been crashed with WebAssembly target due to lack of tail-call support guard in the CoroSplit llvm pass. The crash has been fixed by llvm/llvm-project@8c5c4d9 but the new codegen produces slightly different IR (
callinstead oftail call, while they are lowered to the same wasm instruction). So this patch adds new checks for wasm target.