[cxx-interop] Refer to SwiftBridging module from usr/include/module.modulemap
#72186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e.modulemap` The recent Clang compiler change makes `-fno-modulemap-allow-subdirectory-search` the default behavior. This means that projects that use C++ interop and `#include <swift/bridging>` no longer compile, since Clang won't search for the SwiftBridging module under `usr/include/swift` anymore. This change adds a new modulemap file to be installed at `toolchain/usr/include/module.modulemap`. This modulemap is under a default Clang include search path, which will make sure Clang can discover the SwiftBridging module. rdar://123334601
|
@swift-ci please smoke test |
|
@swift-ci please test |
|
@swift-ci please build toolchain macOS |
|
For the record, upon seeing By the way, this approach works with a test project too. |
|
@swift-ci please smoke test |
|
@swift-ci please test |
|
@swift-ci please build toolchain macOS |
…tter testability rdar://123334601
egorzhdan
force-pushed
the
egorzhdan/swift-bridging-modulemap
branch
from
560d792
to
d494632
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test |
|
@swift-ci please build toolchain macOS |
egorzhdan
added a commit
to swiftlang/swift-installer-scripts
that referenced
this pull request
Mar 11, 2024
|
swiftlang/swift-installer-scripts#282 @swift-ci please build toolchain Windows platform |
|
swiftlang/swift-installer-scripts#282 @swift-ci please test Windows |
|
@swift-ci please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent Clang compiler change makes
-fno-modulemap-allow-subdirectory-searchthe default behavior. This means that projects that use C++ interop and#include <swift/bridging>no longer compile, since Clang won't search for the SwiftBridging module underusr/include/swiftanymore.This change adds a new modulemap file to be installed at
toolchain/usr/include/module.modulemap. This modulemap is under a default Clang include search path, which will make sure Clang can discover the SwiftBridging module.rdar://123334601