Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sending] Remove transferring. #74610

Conversation

gottesmm
Copy link
Contributor

Out of an abundance of caution, we:

  1. Left in parsing support for transferring but internally made it rely on the internals of sending.

  2. Added a warning to tell people that transferring was going to be removed very soon.

Now that we have given people some time, remove support for parsing transferring.

rdar://130253724

@gottesmm
Copy link
Contributor Author

I need to do the swift parser part of this

Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray, the mix of wording was getting confusing :) LGTM

@gottesmm
Copy link
Contributor Author

swiftlang/swift-syntax#2692
@swift-ci smoke test

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also rip out parsing of transferring in swift-syntax?

Edit: Sorry, didn’t see your swift-syntax PR, sorry.

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parser changes look good

Out of an abundance of caution, we:

1. Left in parsing support for transferring but internally made it rely on the
internals of sending.

2. Added a warning to tell people that transferring was going to
be removed very soon.

Now that we have given people some time, remove support for parsing
transferring.

rdar://130253724
@gottesmm gottesmm force-pushed the pr-324fd70c13e87a329334341aae4667f2d1be152c branch from b6c6c32 to 112071e Compare June 21, 2024 23:03
@gottesmm
Copy link
Contributor Author

swiftlang/swift-syntax#2692
@swift-ci smoke test

@gottesmm gottesmm merged commit 34195ff into swiftlang:main Jul 2, 2024
3 checks passed
@gottesmm gottesmm deleted the pr-324fd70c13e87a329334341aae4667f2d1be152c branch July 2, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants