-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sending] Remove transferring. #74610
[sending] Remove transferring. #74610
Conversation
I need to do the swift parser part of this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hooray, the mix of wording was getting confusing :) LGTM
swiftlang/swift-syntax#2692 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also rip out parsing of transferring
in swift-syntax?
Edit: Sorry, didn’t see your swift-syntax PR, sorry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parser changes look good
Out of an abundance of caution, we: 1. Left in parsing support for transferring but internally made it rely on the internals of sending. 2. Added a warning to tell people that transferring was going to be removed very soon. Now that we have given people some time, remove support for parsing transferring. rdar://130253724
b6c6c32
to
112071e
Compare
swiftlang/swift-syntax#2692 |
Out of an abundance of caution, we:
Left in parsing support for transferring but internally made it rely on the internals of sending.
Added a warning to tell people that transferring was going to be removed very soon.
Now that we have given people some time, remove support for parsing transferring.
rdar://130253724