Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] set as python library to be able to install it from pypi with pip #4

Closed
wants to merge 10 commits into from

Conversation

oscarolar
Copy link

No description provided.

@moylop260
Copy link

@apple314159
Copy link
Owner

Well, I'm extremely disappointed. I don't see how you can change the
license.
You don't have the right to do that. Please change it ASAP!

On Thu, Sep 3, 2015 at 6:56 PM, moylop260 notifications@github.com wrote:

@apple314159 https://github.com/apple314159
FYI https://pypi.python.org/pypi/panamadv


Reply to this email directly or view it on GitHub
#4 (comment).

@oscarolar
Copy link
Author

Sorry about that, fixed, It was not my intention to do that.

description="Program to calculate the DV for the given RUC for Panama.",
long_description=readme + '\n\n' + history,
author="Jose Vasconcellos",
author_email='info@vauxoo.com',
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apple314159 can you tell provide me a vali e-mail addres to put it in here?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First off, thank you for addressing the license issue and I'm sorry if I've
overreacted.
For the email, please use vasmac+github@gmail.com.

I'll update the copyright issue this weekend.

On Thu, Sep 3, 2015 at 8:14 PM, Olar Alca [Vauxoo] <notifications@github.com

wrote:

In setup.py
#4 (comment):

+requirements = [

  • TODO: put package requirements here

+]
+
+test_requirements = [

  • TODO: put package test requirements here

+]
+
+setup(

  • name='panamadv',
  • version='0.1.1',
  • description="Program to calculate the DV for the given RUC for Panama.",
  • long_description=readme + '\n\n' + history,
  • author="Jose Vasconcellos",
  • author_email='info@vauxoo.com',

@apple314159 https://github.com/apple314159 can you tell provide me a
vali e-mail addres to put it in here?


Reply to this email directly or view it on GitHub
https://github.com/apple314159/panama-dv/pull/4/files#r38714094.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, now fixed, if you dont have any other concern merge when you consider.
thanks for your great contribution!

@moylop260
Copy link

@apple314159
What do you think of this PR?

FYI we can add a auto pip upload script by each git push with travis-ci but we need have permissions to write in this project (to generate encrypt environment and enable travis-ci).

We are maintainers of other communities:

...and we know respect no-push directly, only by PR changes approved by you.
But this allow it install your library with:
pip install panama-dv==GIT_TAG.GIT_NUM_COMMITS
More info here: http://docs.openstack.org/developer/pbr/
And here: http://docs.travis-ci.com/user/deployment/pypi/

@moylop260
Copy link

@oscarolar
The build folders should be delete to minimize the pr changes and auto create build folder from travis...

@apple314159
Copy link
Owner

When I go to https://pypi.python.org/pypi/panamadv/ I see that you listed
the project with a BSD license.
My project is distributed with an Apache license (see LICENSE file). I've
already communicated with you
on this issue and you've agreed to change it. You keep requesting changes
but you haven't done what
you said you would do.

On Mon, Sep 7, 2015 at 1:28 AM, moylop260 notifications@github.com wrote:

@oscarolar https://github.com/oscarolar
The build folders should be delete to minimize the pr changes and auto
create build folder from travis...


Reply to this email directly or view it on GitHub
#4 (comment).

@moylop260
Copy link

You are right!
Sorry for that.

Changed
https://github.com/apple314159/panama-dv

Please, don't merge this PR, I will work with travis, coveralls, pep8... (If you are agree with me)

@moylop260
Copy link

This pr deprecated by #6

@oscarolar oscarolar closed this Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants