Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multistage Docker build with scratch container #119

Closed
wants to merge 2 commits into from

Conversation

joshdk
Copy link
Contributor

@joshdk joshdk commented Mar 6, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 6, 2018

Codecov Report

Merging #119 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #119   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines         107    107           
=====================================
  Hits          107    107

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c0b475...a1a8acb. Read the comment docs.

@appleboy
Copy link
Owner

appleboy commented Mar 8, 2018

I think ssh can't work in scratch container.

@appleboy appleboy closed this Mar 8, 2018
@joshdk
Copy link
Contributor Author

joshdk commented Mar 9, 2018

@appleboy I can confirm that this works, as I'm using a custom image (build out of #119 rebased on top of #118) in our Drone testing environment. I actually think that this docker file actually adds too much, as SSL certificates are not needed for SSH.

Were you seeing issues running the container? I would be happy to take a look at any errors.

@appleboy
Copy link
Owner

I will try this container using scratch as base image. If so, just change alpine to plugins/base:multiarch image.

See https://hub.docker.com/r/plugins/base/tags/

We don't need the multiple stage in Dockerfile.

@appleboy
Copy link
Owner

appleboy commented Mar 4, 2019

@joshdk Now drone-ssh already run in the scratch base container.

@appleboy appleboy closed this Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants