Skip to content

Commit

Permalink
fixed small error in connect_vertex() for pin hole cameras.
Browse files Browse the repository at this point in the history
connect the point to the camera pin hole ("lens"), not to the film.
  • Loading branch information
dictoon committed Mar 24, 2015
1 parent 3922d6e commit 961892d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/appleseed/renderer/modeling/camera/pinholecamera.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -210,10 +210,10 @@ namespace
const Transformd& transform = m_transform_sequence.evaluate(time, tmp);

// Compute the outgoing direction vector in world space.
const Vector3d film_point = ndc_to_camera(ndc);
outgoing = point - transform.point_to_parent(film_point);
outgoing = point - transform.get_local_to_parent().extract_translation();

// Compute the emitted importance.
const Vector3d film_point = ndc_to_camera(ndc);
const double square_dist_film_lens = square_norm(film_point);
const double dist_film_lens = sqrt(square_dist_film_lens);
const double cos_theta = m_focal_length / dist_film_lens;
Expand Down

0 comments on commit 961892d

Please sign in to comment.